W-7780834 BDI Donation Stage Defaults to "Opportunity Stage When Fully Paid" value #6810
Conversation
mldyang
changed the title
| } else { | ||
| defaultClosedWonStage = ''; | ||
| // if no field is specified in contact setting, then query for the active isWon value and use that |
There was a problem hiding this comment.
| // if no field is specified in contact setting, then query for the active isWon value and use that | |
| // if no stage name is specified in contact setting, then query for the active isWon value and use that |
| * in Contact Setting Payments_Auto_Close_Stage_Name__c | ||
| */ | ||
| @IsTest | ||
| static void donationShouldUseDIDonationStage() { |
There was a problem hiding this comment.
These two tests are good, but I would consider combining them into one unit test with two data import records to reduce the total number of DML statements and trigger run time (just concerned about total test execution time). Also you could consider just running these synchronously with BDI_DataImport_API.processDataImportRecords instead of batch execution which should save a little more processing time but not effect the outcome. If these didn't involve DML I would agree its cleaner to have them separate.
There was a problem hiding this comment.
Implemented, thanks for the suggestions!
| WHERE IsActive = TRUE | ||
| AND IsWon = TRUE | ||
| ]; | ||
| if (stages.size() > 0) { |
There was a problem hiding this comment.
We could replace these 5 lines of code with the following:
defaultClosedWonStage = stages.size()>0 ? stages[0].MasterLabel : '';
There was a problem hiding this comment.
Cool. Implemented, thanks!
Fixed the issue where BDI Donation Stage ignores Opportunity Stage When Fully Paid value. Now, if "Opportunity Stage When Fully Paid" setting has a value, the default Donation Stage will be set to that value.
(Note that DI's Donation Stage, if different than Opportunity Stage When Fully Paid value, will take precedence)
For reference, here is a table summarizing expected results https://salesforce.quip.com/hW4eA11a5zFd
Critical Changes
Changes
NPSP Data Importer Enhancements
Issues Closed
Community Ideas Delivered
Features Intended for Future Release
Features for Elevate Customers
New Metadata
Deleted Metadata